[
https://issues.apache.org/jira/browse/GOBBLIN-1920?focusedWorklogId=881776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881776
]
ASF GitHub Bot logged work on GOBBLIN-1920:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/23 20:35
Start Date: 25/Sep/23 20:35
Worklog Time Spent: 10m
Work Description: prasadkarkera commented on code in PR #3788:
URL: https://github.com/apache/gobblin/pull/3788#discussion_r1336362439
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -277,8 +277,9 @@ public static JobDataMap updatePropsInJobDataMap(JobDataMap
jobDataMap,
// Saves the following properties in jobProps to retrieve when the trigger
fires
prevJobProps.setProperty(ConfigurationKeys.SCHEDULER_EXPECTED_REMINDER_TIME_MILLIS_KEY,
String.valueOf(getUTCTimeFromDelayPeriod(delayPeriodMillis)));
+ // We use the db laundered timestamp for the reminder to ensure consensus
between hosts
prevJobProps.setProperty(ConfigurationKeys.SCHEDULER_PRESERVED_CONSENSUS_EVENT_TIME_MILLIS_KEY,
- String.valueOf(triggerEventTimeMillis));
Review Comment:
We can probably remove this from function parameter as well?
Issue Time Tracking
-------------------
Worklog Id: (was: 881776)
Time Spent: 20m (was: 10m)
> Use DB event timestamp for MA Reminder events
> ---------------------------------------------
>
> Key: GOBBLIN-1920
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1920
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When setting the reminder event we use the trigger time local to each host.
> Instead we want to use the timestamp from database to see consistency between
> hosts in case their clock drift is significant.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
