meethngala commented on code in PR #3776: URL: https://github.com/apache/gobblin/pull/3776#discussion_r1337707970
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagTask.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.orchestration; + +import java.io.IOException; +import java.util.Properties; + +import org.apache.gobblin.runtime.api.DagActionStore; +import org.apache.gobblin.runtime.api.MultiActiveLeaseArbiter; + + +/** + * Defines an individual task or job in a Dag. + * It carries the state information required by {@link DagProc} to for its processing. + * Upon completion of the {@link DagProc#process()} it will mark the lease + * acquired by {@link org.apache.gobblin.runtime.api.MultiActiveLeaseArbiter} as complete + * @param <T> + */ +@WorkInProgress +public abstract class DagTask<T> { + + protected Properties jobProps; + protected DagActionStore.DagAction flowAction; + protected long triggerTimeStamp; + + protected MultiActiveLeaseArbiter.LeaseAttemptStatus leaseAttemptStatus; Review Comment: I agree to your suggestion and have updated the code based on your inputs. The latest commit handles these changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
