[
https://issues.apache.org/jira/browse/GOBBLIN-1926?focusedWorklogId=884367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-884367
]
ASF GitHub Bot logged work on GOBBLIN-1926:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/23 20:23
Start Date: 10/Oct/23 20:23
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3797:
URL: https://github.com/apache/gobblin/pull/3797#issuecomment-1756167876
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3797?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3797](https://app.codecov.io/gh/apache/gobblin/pull/3797?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(af663be) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/e4cae2e3c559691f8b8873f81ab805c8a6482fd2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(e4cae2e) will **decrease** coverage by `1.19%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3797 +/- ##
============================================
- Coverage 47.33% 46.14% -1.19%
+ Complexity 10971 2181 -8790
============================================
Files 2152 416 -1736
Lines 85149 17965 -67184
Branches 9467 2191 -7276
============================================
- Hits 40302 8290 -32012
+ Misses 41190 8792 -32398
+ Partials 3657 883 -2774
```
[see 1740 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3797/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 884367)
Time Spent: 20m (was: 10m)
> Reminder event lease acquisition epsilon comparison fix
> -------------------------------------------------------
>
> Key: GOBBLIN-1926
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1926
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> For a large number of reminder events, we are still seeing the event be
> considered distinct and launching a separate execution. Analysis of the
> reminder events being considered unique shows that reminder eventTimestamps
> that are well in the past are handled properly by this
> [case|https://github.com/apache/gobblin/blob/e4cae2e3c559691f8b8873f81ab805c8a6482fd2/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiter.java#L296].
> However, a large number of reminder events fall into the case of being
> exactly equal to the timestamp in the database. Those are handled improperly
> by falling into [CASE
> 6|https://github.com/apache/gobblin/blob/e4cae2e3c559691f8b8873f81ab805c8a6482fd2/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiter.java#L347]
> of the same event time lease completed yet we were considering the reminder
> event to be unique. This is because we were comparing the _current timestamp_
> in the database to the _db event timestamp_ to determine uniqueness. However,
> we always want to utilize the _event timestamp_ the reminder is for, since
> _linger_ time will have passed and the event would be considered unique if
> using the former check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
