[
https://issues.apache.org/jira/browse/GOBBLIN-1931?focusedWorklogId=885765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-885765
]
ASF GitHub Bot logged work on GOBBLIN-1931:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/23 00:41
Start Date: 18/Oct/23 00:41
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3801:
URL: https://github.com/apache/gobblin/pull/3801
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1931
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
Small refactor to improve coding style of `updateFlowExecutionId` method of
`DagAction`. Add an additional clarifying comment to ensure the right
`DagActions` are used.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 885765)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor dag action method & add clarifying comment
> ---------------------------------------------------
>
> Key: GOBBLIN-1931
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1931
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Small refactor to improve coding style of updateFlowExecutionId method of
> DagAction. Add an additional clarifying comment to ensure the right
> DagActions are used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
