phet commented on code in PR #3805:
URL: https://github.com/apache/gobblin/pull/3805#discussion_r1369650582


##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/kafka/HighLevelConsumer.java:
##########
@@ -197,6 +201,22 @@ protected void shutdownMetrics() throws IOException {
    */
   protected void createMetrics() {
     this.messagesRead = 
this.metricContext.counter(RuntimeMetrics.GOBBLIN_KAFKA_HIGH_LEVEL_CONSUMER_MESSAGES_READ);
+    this.queueSizeGauges = new ContextAwareGauge[numThreads];
+    this.queueSizeGaugeValues = new AtomicIntegerArray(numThreads);
+    for (int i=0; i < numThreads; i++) {
+      int finalI = i;
+      this.queueSizeGauges[i] = this.metricContext.newContextAwareGauge(
+          RuntimeMetrics.GOBBLIN_KAFKA_HIGH_LEVEL_CONSUMER_QUEUE_SIZE + "-" + 
i,
+          () -> queueSizeGaugeValues.get(finalI));

Review Comment:
   w/o a comment to explain the rationale, I'm left to wonder: why couldn't 
this be written:
   ```
   () -> queues[finalI].size()
   ```
   ?
   
   that would dispense w/ the need for `queueSizeGaugeValues` and with it the 
potential perf hit of updating that array upon every enqueing.
   
   and on that topic... why is `updateQueueSizes` only recalculated at enqueue 
time, rather than at dequeue time as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to