[ 
https://issues.apache.org/jira/browse/GOBBLIN-1935?focusedWorklogId=887072&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887072
 ]

ASF GitHub Bot logged work on GOBBLIN-1935:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Oct/23 22:16
            Start Date: 24/Oct/23 22:16
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3807:
URL: https://github.com/apache/gobblin/pull/3807#discussion_r1370870646


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -123,6 +123,12 @@ protected void processMessage(DecodeableKafkaRecord 
message) {
     String flowName = value.getFlowName();
     String flowExecutionId = value.getFlowExecutionId();
 
+    if (value.getDagAction() == null) {
+      log.warn("Skipping null dag action type received for flow group: {} 
name: {} executionId: {} tid: {} operation: "
+          + "{}", flowGroup, flowName, flowExecutionId, tid, operation);
+      this.messageFilteredOutMeter.mark();

Review Comment:
   does it make sense to mix w/ what this is already tracking?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 887072)
    Time Spent: 20m  (was: 10m)

> Skip null dag action types unable to be processed
> -------------------------------------------------
>
>                 Key: GOBBLIN-1935
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1935
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Malformed Kafka messages with Null DagActionTypes are causing NPE to be 
> thrown and interrupt the entire thread & queue processing. These messages are 
> introduced during restart/deploy. We want to be able to handle any 
> problematic input from Kafka and skip over these messages gracefully. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to