Will-Lo commented on code in PR #3784:
URL: https://github.com/apache/gobblin/pull/3784#discussion_r1373728072
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java:
##########
@@ -539,7 +537,7 @@ private void deleteWorkUnitFromStateStore(String
workUnitId, ParallelRunner stat
Path workUnitFile = new Path(workUnitFilePath);
final String fileName = workUnitFile.getName();
final String storeName = workUnitFile.getParent().getName();
- if (fileName.endsWith(MULTI_WORK_UNIT_FILE_EXTENSION)) {
+ if (fileName.endsWith(JobLauncherUtils.MULTI_WORK_UNIT_FILE_EXTENSION)) {
Review Comment:
I see this sort of check a lot in this PR, does it make sense to make it a
reusable function of JobLauncherUtils where we check if a given path/string is
a multiworkunit file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
