[
https://issues.apache.org/jira/browse/GOBBLIN-1919?focusedWorklogId=887453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887453
]
ASF GitHub Bot logged work on GOBBLIN-1919:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/23 19:37
Start Date: 26/Oct/23 19:37
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3784:
URL: https://github.com/apache/gobblin/pull/3784#discussion_r1373728072
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java:
##########
@@ -539,7 +537,7 @@ private void deleteWorkUnitFromStateStore(String
workUnitId, ParallelRunner stat
Path workUnitFile = new Path(workUnitFilePath);
final String fileName = workUnitFile.getName();
final String storeName = workUnitFile.getParent().getName();
- if (fileName.endsWith(MULTI_WORK_UNIT_FILE_EXTENSION)) {
+ if (fileName.endsWith(JobLauncherUtils.MULTI_WORK_UNIT_FILE_EXTENSION)) {
Review Comment:
I see this sort of check a lot in this PR, does it make sense to make it a
reusable function of JobLauncherUtils where we check if a given path/string is
a multiworkunit file?
Issue Time Tracking
-------------------
Worklog Id: (was: 887453)
Time Spent: 50m (was: 40m)
> Simplify impl related to MR job execution (before reusing code in
> Temporal-based exec)
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1919
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1919
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Trivial
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)