arjun4084346 commented on code in PR #3804:
URL: https://github.com/apache/gobblin/pull/3804#discussion_r1373779968
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/ManifestBasedDataset.java:
##########
@@ -128,6 +143,12 @@ public Iterator<FileSet<CopyEntity>>
getFileSetIterator(FileSystem targetFs, Cop
toDelete.add(targetFs.getFileStatus(fileToCopy));
}
}
+
+ Properties props = new Properties();
+ props.setProperty(SetPermissionCommitStep.STOP_ON_ERROR_KEY, "true");
+ CommitStep setPermissionCommitStep = new
SetPermissionCommitStep(targetFs, ancestorOwnerAndPermissions, props);
Review Comment:
If dir does not exist, we create it, but we create it with execute bit set.
I do not want to not do that, because execute bit may be necessary to do
publish.
So, in this PR, I had to add a post publish step to set the original
permission.
Honestly, the usecase for this work, unsetting execute bit, seems quite rare.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
