[
https://issues.apache.org/jira/browse/GOBBLIN-1941?focusedWorklogId=887673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887673
]
ASF GitHub Bot logged work on GOBBLIN-1941:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/23 00:16
Start Date: 28/Oct/23 00:16
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3811:
URL: https://github.com/apache/gobblin/pull/3811#discussion_r1375130094
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/util/nesting/workflow/AbstractNestingExecWorkflowImpl.java:
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.temporal.util.nesting.workflow;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.stream.Collectors;
+import java.util.stream.StreamSupport;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.compress.utils.Lists;
+
+import io.temporal.api.enums.v1.ParentClosePolicy;
+import io.temporal.workflow.Async;
+import io.temporal.workflow.ChildWorkflowOptions;
+import io.temporal.workflow.Promise;
+import io.temporal.workflow.Workflow;
+
+import org.apache.gobblin.temporal.util.nesting.work.WFAddr;
+import org.apache.gobblin.temporal.util.nesting.work.Workload;
+
+
+/** Core skeleton of {@link NestingExecWorkflow}: realizing classes need only
define {@link #launchAsyncActivity} */
Review Comment:
I situated that advice in the `NestingExecWorkflow` interface -
https://github.com/apache/gobblin/pull/3811/files#diff-3ca08118c269ccea822f3ebe53b22f513b848369cae1c8ca52f18fc22f200b59R37
(see: line 37)
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/util/nesting/workflow/AbstractNestingExecWorkflowImpl.java:
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.temporal.util.nesting.workflow;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.stream.Collectors;
+import java.util.stream.StreamSupport;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.compress.utils.Lists;
+
+import io.temporal.api.enums.v1.ParentClosePolicy;
+import io.temporal.workflow.Async;
+import io.temporal.workflow.ChildWorkflowOptions;
+import io.temporal.workflow.Promise;
+import io.temporal.workflow.Workflow;
+
+import org.apache.gobblin.temporal.util.nesting.work.WFAddr;
+import org.apache.gobblin.temporal.util.nesting.work.Workload;
+
+
+/** Core skeleton of {@link NestingExecWorkflow}: realizing classes need only
define {@link #launchAsyncActivity} */
Review Comment:
I situated that advice in the `NestingExecWorkflow` interface javadoc -
https://github.com/apache/gobblin/pull/3811/files#diff-3ca08118c269ccea822f3ebe53b22f513b848369cae1c8ca52f18fc22f200b59R37
(see: line 37)
Issue Time Tracking
-------------------
Worklog Id: (was: 887673)
Time Spent: 1h 10m (was: 1h)
> Create abstractions for developing on Temporal
> ----------------------------------------------
>
> Key: GOBBLIN-1941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1941
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Develop abstractions to assist in implementing Gobblin-on-Temporal, including
> to overcome temporal's limitation of 50Ki events per workflow history -
> https://docs.temporal.io/workflows#event-history
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
