phet commented on code in PR #3812:
URL: https://github.com/apache/gobblin/pull/3812#discussion_r1378063750
##########
gobblin-runtime/src/main/java/org/apache/gobblin/util/DBStatementExecutor.java:
##########
@@ -22,24 +22,28 @@
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;
+import java.util.ArrayList;
import java.util.concurrent.ScheduledThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import javax.sql.DataSource;
import org.slf4j.Logger;
/**
- * MySQL based implementations of stores require common functionality that can
be stored in a utility class. The
- * functionality includes executing prepared statements on a data source
object and executing SQL queries at fixed
- * intervals. The instantiater of the class should provide the data source
used within this utility.
+ * Many database stores require common functionality that can be stored in a
utility class. The functionality
+ * includes executing prepared statements on a data source object and SQL
queries at fixed intervals.
+ * The caller of the class MUST maintain ownership of the {@link DataSource}
and close this instance when the
+ * {@link DataSource} is about to be closed well. Both are to be done only
once this instance will no longer be used.
*/
-public class MySQLStoreUtils {
+public class DBStatementExecutor {
Review Comment:
might be nice to implement `Closeable` or `AutoCloseable`... what do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
