[
https://issues.apache.org/jira/browse/GOBBLIN-1944?focusedWorklogId=888146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-888146
]
ASF GitHub Bot logged work on GOBBLIN-1944:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/23 20:42
Start Date: 31/Oct/23 20:42
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3815:
URL: https://github.com/apache/gobblin/pull/3815#discussion_r1378143787
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/loadgen/activity/IllustrationItemActivity.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.temporal.loadgen.activity;
+
+import io.temporal.activity.ActivityInterface;
+import io.temporal.activity.ActivityMethod;
+import org.apache.gobblin.temporal.loadgen.work.IllustrationItem;
+
+
+/**
+ * Activity for processing {@link IllustrationItem}s
+ *
+ * CAUTION/FINDING: an `@ActivityInterface` must not be parameterized (e.g.
here, by WORK_ITEM), as doing so results in:
+ * io.temporal.failure.ApplicationFailure: message='class
java.util.LinkedHashMap cannot be cast to class
+ * org.apache.gobblin.temporal.loadgen.work.IllustrationItem',
type='java.lang.ClassCastException'
Review Comment:
I intentionally added it to document what blocked the refactoring I wished
to do, to be a forewarning to any future maintainer, who might also regard the
change as desirable, but at first might not grasp the challenge
Issue Time Tracking
-------------------
Worklog Id: (was: 888146)
Time Spent: 20m (was: 10m)
> Create Gobblin-Temporal load-generator to de-risk Temporal's scaling
> --------------------------------------------------------------------
>
> Key: GOBBLIN-1944
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1944
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> To de-risk Temporal as an effective platform for executing Gobblin jobs, we
> must validate that temporal workflows can scale-up to a Big Data number of
> activities. To perform such load testing, build a load-generator for creating
> nesting workflows that ultimately subsume whatever configurable number of
> activities.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
