ZihanLi58 commented on code in PR #3814:
URL: https://github.com/apache/gobblin/pull/3814#discussion_r1378260990
##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaTopicGroupingWorkUnitPacker.java:
##########
@@ -381,4 +391,40 @@ static double getContainerCapacityForTopic(List<Double>
capacities, ContainerCap
throw new RuntimeException("Unsupported computation strategy: " +
strategy.name());
}
}
+
+ /**
+ * A method that split a list of {@link MultiWorkUnit} to the size of
desiredWUSize if possible. The split approach is to
Review Comment:
Add comments here to mention that we always try to split MWU with more
partitions first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
