[
https://issues.apache.org/jira/browse/GOBBLIN-1948?focusedWorklogId=888498&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-888498
]
ASF GitHub Bot logged work on GOBBLIN-1948:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Nov/23 18:55
Start Date: 02/Nov/23 18:55
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3819:
URL: https://github.com/apache/gobblin/pull/3819
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1948
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
A consistent `flowExecutionId` is used during lease arbitration between
hosts and that id is available to the `DagActionStoreChangeMonitor` but not
used when passing `launch` events to the `Orchestrator` for recompilation and
eventual execution. The unintended consequence of this is that a different
`flowExecutionId` will be used across each participant when the flow is
recompiled before passing to the `DagManager`. This messes up the job status of
the most recent flow execution of each flow as it appears there are `N flow
execution Ids`, 1 for each of the `N` hosts. Only one will be executed but the
other `N-1` are stuck in `"compiling"` job status state.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tests `addProperty` method added
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 888498)
Remaining Estimate: 0h
Time Spent: 10m
> Use Consist flowExecutionId Across Participants
> -----------------------------------------------
>
> Key: GOBBLIN-1948
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1948
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A consistent flowExecutionId is used during lease arbitration between hosts
> and that id is available to the DagActionStoreChangeMonitor but not used when
> passing launch events to the Orchestrator for recompilation and eventual
> execution. The unintended consequence of this is that a different
> flowExecutionId will be used across each participant when the flow is
> recompiled before passing to the DagManager. This messes up the job status of
> the most recent flow execution of each flow as it appears there are N flow
> execution Ids, 1 for each of the N hosts. Only one will be executed but the
> other N-1 are stuck in "compiling" job status state.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
