[
https://issues.apache.org/jira/browse/GOBBLIN-1949?focusedWorklogId=888517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-888517
]
ASF GitHub Bot logged work on GOBBLIN-1949:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Nov/23 21:54
Start Date: 02/Nov/23 21:54
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3818:
URL: https://github.com/apache/gobblin/pull/3818#issuecomment-1791590596
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3818?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3818](https://app.codecov.io/gh/apache/gobblin/pull/3818?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(24c58bc) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/da6b1dfd02400b6aafe5a650a6fb8d9388cdac0f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(da6b1df) will **decrease** coverage by `1.54%`.
> Report is 3 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3818 +/- ##
============================================
- Coverage 47.63% 46.10% -1.54%
+ Complexity 11047 2187 -8860
============================================
Files 2155 416 -1739
Lines 85322 17984 -67338
Branches 9488 2194 -7294
============================================
- Hits 40645 8291 -32354
+ Misses 40984 8813 -32171
+ Partials 3693 880 -2813
```
[see 1747 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3818/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 888517)
Time Spent: 20m (was: 10m)
> Add option to detect malformed orc during commit
> ------------------------------------------------
>
> Key: GOBBLIN-1949
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1949
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Hanghang Liu
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Hot fix for malformed ORC file issue.
> The issue was observed during compaction that the malformed ORC can’t be
> opened. There're two scenarios of malformed file, one is the file only
> contains the last keyword of Postscript, meaning the byte of "ORC" is written
> to the file. Another situation is the file contains concrete data but doesn't
> end properly so read will fail when ReaderImplextractPostScript().
> The fix is to add an validation step of the ORC file during commit, more
> specifically after close the writer and before commit. This can prevent the
> malformed data being moved the output direction and even published to
> destination.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
