umustafi commented on code in PR #3823:
URL: https://github.com/apache/gobblin/pull/3823#discussion_r1391792468
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -484,7 +484,9 @@ public synchronized void setActive(boolean active) {
log.error("Exception encountered when shutting down DagManager
threads.", e);
}
}
- } catch (IOException e) {
+ } catch (Throwable e) {
Review Comment:
I am updating it to catch `RuntimeException` then. How about that for the
error catching?
I was thinking about setting this.active after we finish all the work, but
the reason we may set it before is that loading all dags from state store and
initializing may take time but in meantime we still want to accept new
requests. I want to limit scope of significant change like that which may
increase downtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
