phet commented on code in PR #3824:
URL: https://github.com/apache/gobblin/pull/3824#discussion_r1393010086
##########
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/ServiceMetricNames.java:
##########
@@ -44,7 +44,8 @@ public class ServiceMetricNames {
public static final String FLOW_TRIGGER_HANDLER_JOB_DOES_NOT_EXIST_COUNT =
FLOW_TRIGGER_HANDLER_PREFIX + "jobDoesNotExistInScheduler";
public static final String FLOW_TRIGGER_HANDLER_FAILED_TO_SET_REMINDER_COUNT
= FLOW_TRIGGER_HANDLER_PREFIX + "failedToSetReminderCount";
public static final String
FLOW_TRIGGER_HANDLER_LEASES_OBTAINED_DUE_TO_REMINDER_COUNT =
FLOW_TRIGGER_HANDLER_PREFIX + "leasesObtainedDueToReminderCount";
- public static final String
FLOW_TRIGGER_HANDLER_FAILED_PERSISTING_LEASE_COUNT =
FLOW_TRIGGER_HANDLER_PREFIX + "failedPersistingLeaseCount";
+ public static final String
FLOW_TRIGGER_HANDLER_FAILED_TO_RECORD_LEASE_SUCCESS_COUNT =
FLOW_TRIGGER_HANDLER_PREFIX + "failedtoRecordLeaseSuccessCount";
Review Comment:
above on line 46, looks like we capitalize 'To' within camel-case
##########
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/ServiceMetricNames.java:
##########
@@ -44,7 +44,8 @@ public class ServiceMetricNames {
public static final String FLOW_TRIGGER_HANDLER_JOB_DOES_NOT_EXIST_COUNT =
FLOW_TRIGGER_HANDLER_PREFIX + "jobDoesNotExistInScheduler";
public static final String FLOW_TRIGGER_HANDLER_FAILED_TO_SET_REMINDER_COUNT
= FLOW_TRIGGER_HANDLER_PREFIX + "failedToSetReminderCount";
public static final String
FLOW_TRIGGER_HANDLER_LEASES_OBTAINED_DUE_TO_REMINDER_COUNT =
FLOW_TRIGGER_HANDLER_PREFIX + "leasesObtainedDueToReminderCount";
- public static final String
FLOW_TRIGGER_HANDLER_FAILED_PERSISTING_LEASE_COUNT =
FLOW_TRIGGER_HANDLER_PREFIX + "failedPersistingLeaseCount";
+ public static final String
FLOW_TRIGGER_HANDLER_FAILED_TO_RECORD_LEASE_SUCCESS_COUNT =
FLOW_TRIGGER_HANDLER_PREFIX + "failedtoRecordLeaseSuccessCount";
+ public static final String
FLOW_TRIGGER_HANDLER_COMPLETED_RECORD_LEASE_SUCCESS_COUNT =
FLOW_TRIGGER_HANDLER_PREFIX + "completedRecordLeaseSuccessCount";
Review Comment:
nit: `recordedLeaseSuccessCount`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
