[
https://issues.apache.org/jira/browse/GOBBLIN-1956?focusedWorklogId=890592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890592
]
ASF GitHub Bot logged work on GOBBLIN-1956:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/23 01:06
Start Date: 15/Nov/23 01:06
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3827:
URL: https://github.com/apache/gobblin/pull/3827#issuecomment-1811638411
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base
[(`315d959`)](https://app.codecov.io/gh/apache/gobblin/commit/315d9599e08521dd71ae6dccb09b7f7254961564?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
47.55% compared to head
[(`807027f`)](https://app.codecov.io/gh/apache/gobblin/pull/3827?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
46.00%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3827 +/- ##
============================================
- Coverage 47.55% 46.00% -1.55%
+ Complexity 11031 2181 -8850
============================================
Files 2156 416 -1740
Lines 85370 17984 -67386
Branches 9491 2194 -7297
============================================
- Hits 40594 8274 -32320
+ Misses 41080 8827 -32253
+ Partials 3696 883 -2813
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3827?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 890592)
Time Spent: 20m (was: 10m)
> Make Kafka streaming pipeline be able to config the max poll records during
> runtime
> -----------------------------------------------------------------------------------
>
> Key: GOBBLIN-1956
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1956
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Kafka max.poll.records affect the performance of the Kafka consumer.
> Config it to be a lower number means it take more time to process each
> record. While config it to be a higher number means we need more memory to
> hold the records. So we should use the avg record size to determine the value
> for different topics.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
