umustafi opened a new pull request, #3841: URL: https://github.com/apache/gobblin/pull/3841
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1970 ### Description - [X] Here are some details about my PR, including screenshots (if applicable): We have similar code in the `DagActionStoreChangeMonitor` and `DagManager` to process dag actions from the `DagActionStore`. There have been small discrepancies between the code in each area leading to unexpected bugs in how the actions are processed, so to fix forward and make this easier to maintain with code in one place we consolidate all logic relating to the dag action processing to the `DagActionStoreChangeMonitor`. The processing in the change monitor is working correctly, while the handling of launch events in the `DagManager` is failing compilation most likely due to an error loading the job templates when initializing the compiler but we're not able to identify the exact issue. ### Tests - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
