homatthew commented on code in PR #3843:
URL: https://github.com/apache/gobblin/pull/3843#discussion_r1416350466


##########
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java:
##########
@@ -135,10 +135,6 @@ public void run() {
 
   @Override
   public void cancel() throws Exception {
-    try {
-      this.gobblinYarnAppLauncher.stop();
-    } finally {
-      super.cancel();

Review Comment:
   This is not necessary because super.cancel throws a not implemented 
exception, causing clutter in the logging



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to