phet commented on code in PR #3849:
URL: https://github.com/apache/gobblin/pull/3849#discussion_r1428322518
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -720,6 +720,8 @@ private void cancelDagNode(DagNode<JobExecutionPlan>
dagNodeToCancel) throws Exe
String serializedFuture =
DagManagerUtils.getSpecProducer(dagNodeToCancel).serializeAddSpecResponse(future);
props.put(ConfigurationKeys.SPEC_PRODUCER_SERIALIZED_FUTURE,
serializedFuture);
sendCancellationEvent(dagNodeToCancel.getValue());
+ } else {
+ log.warn("No Job future when canceling DAG node (hence, not sending
cancellation event) - {}", dagNodeToCancel.getValue().getJobSpec().getUri());
Review Comment:
not strictly related... just sprinkling in better logging concerning a
question I was recently pondering during another investigation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
