arjun4084346 commented on code in PR #3851:
URL: https://github.com/apache/gobblin/pull/3851#discussion_r1435221314
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -136,6 +142,23 @@ protected void initializeMonitor() {
}
}
+ /*
+ Override this method to do the same sequence as the parent class, except
create metrics. Instead, we create metrics
+ earlier upon class initialization because they are used immediately as dag
actions are loaded and processed from
+ the DagActionStore.
+ */
+ @Override
+ protected void startUp() {
Review Comment:
Can we just move buildMetricsContextAndMetrics() to the constructor of
HighLevelConsumer and avoid overriding startUp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
