[
https://issues.apache.org/jira/browse/GOBBLIN-1978?focusedWorklogId=896925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-896925
]
ASF GitHub Bot logged work on GOBBLIN-1978:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/23 17:35
Start Date: 22/Dec/23 17:35
Worklog Time Spent: 10m
Work Description: umustafi commented on PR #3851:
URL: https://github.com/apache/gobblin/pull/3851#issuecomment-1867927129
> Can we just move buildMetricsContextAndMetrics() to the constructor of
HighLevelConsumer and avoid overriding startUp?
A lot of existing tests need to be refactored if I do this and may end up
having some unintended consequences I don't want to cause right now. I want to
verify if this is the only issue first.
Issue Time Tracking
-------------------
Worklog Id: (was: 896925)
Time Spent: 40m (was: 0.5h)
> Create DagActionStoreMonitor metrics before Loading DagActions
> --------------------------------------------------------------
>
> Key: GOBBLIN-1978
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1978
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We encounter a NullPointerException when initializing the
> DagActionStoreMonitor after moving the loading of DagActions on startup from
> the DagManager to the DagActionStoreMonitor. Metrics for the
> DagActionStoreMonitor were initialized by its parent class the
> HighLevelConsumer only before starting to consume Kafka messages, however
> with the refactor these metrics are needed beforehand. In this PR I separate
> the creation of these metrics into a separate function and call it before
> loading dagActions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
