phet commented on code in PR #3853:
URL: https://github.com/apache/gobblin/pull/3853#discussion_r1445037002
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtils.java:
##########
@@ -366,4 +396,63 @@ static List<String> getDistinctUniqueRequesters(String
serializedRequesters) {
throw new RuntimeException("Could not process requesters due to ", e);
}
}
+
+ public static void
submitInitializationEventsAndSetStatus(Dag<JobExecutionPlan> dag,
Optional<EventSubmitter> eventSubmitter) {
Review Comment:
given the entire body is skipped when absent (e.g. you don't even set status
when not submitting), it may be clearer to phrase as:
```
submitAndSet(Dag<JEP> dag, EventSubmitter es)
```
for use as:
```
eventSubmitter.ifPresent(es -> submitAndSet(dag, es));
```
to promote that, let's rid ourselves of the antiquated guava `Optional` in
favor of the java8 one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
