[
https://issues.apache.org/jira/browse/GOBBLIN-1985?focusedWorklogId=899479&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899479
]
ASF GitHub Bot logged work on GOBBLIN-1985:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/24 19:36
Start Date: 12/Jan/24 19:36
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3859:
URL: https://github.com/apache/gobblin/pull/3859#discussion_r1450853426
##########
gobblin-utility/src/main/java/org/apache/gobblin/util/FileListUtils.java:
##########
@@ -125,8 +125,17 @@ public static List<FileStatus>
listFilesRecursively(FileSystem fs, Path path, Pa
public static List<FileStatus> listFilesRecursively(FileSystem fs, Path
path, PathFilter fileFilter,
boolean applyFilterToDirectories)
throws IOException {
- return listFilesRecursivelyHelper(fs, Lists.newArrayList(),
fs.getFileStatus(path), fileFilter,
- applyFilterToDirectories, false);
+ return listFilesRecursively(fs, fs.getFileStatus(path), fileFilter,
applyFilterToDirectories);
+ }
+
+ /**
+ * Helper method to list out all files under a specified {@link FileStatus}.
If applyFilterToDirectories is false, the supplied
+ * {@link PathFilter} will only be applied to files.
+ */
+ public static List<FileStatus> listFilesRecursively(FileSystem fs,
FileStatus beneathThisFile, PathFilter fileFilter,
Review Comment:
just avoids accessing the `getFileStatus` twice (since we already had been
doing this internally for the recursion helper)
Issue Time Tracking
-------------------
Worklog Id: (was: 899479)
Time Spent: 0.5h (was: 20m)
> Incorporate the mod time of enclosing dirs into the `SourceHadoopFsEndPoint`
> watermark calculations
> ---------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1985
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1985
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> `SourceHadoopFsEndPoint.getWatermark` currently misses certain changes to the
> contents of the dirs it covers because it doesn't use the mod time of those
> enclosing dirs when calculating the watermark. despite those dirs not being
> among the files to copy, they must still participate in the watermark
> calculation because some compute engines, like spark, first write files to a
> temp subdir beneath the ultimate dest dir. (since those temp subdirs are not
> valid paths, they'll anyway be skipped.) once all executors have written
> their file, spark moves each from that temp subdir up to the enclosing
> ultimate dir location. such file movement DOES NOT update the mod time of
> the file itself, only that of its enclosing dir--hence the need to
> incorporate the enclosing dir's mod time, in order to observe such dir
> changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)