phet commented on code in PR #3857:
URL: https://github.com/apache/gobblin/pull/3857#discussion_r1450991878
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpec.java:
##########
@@ -75,13 +78,22 @@ public class FlowSpec implements Configurable, Spec {
/** Human-readable description of the flow spec */
final String description;
- /** Flow config as a typesafe config object */
- final Config config;
+ /* Note that since getConfig() and getConfigAsProperties() are independent
accessors, `volatile` doesn't ensure a
+ * consistent view between them. In a multi-threaded scenario one should use
the following access mechanism:
+ * FlowSpec fs = ...
+ * synchronized (fs) {
Review Comment:
in fact, the new potential to mutate via `addProperty` means that
`getProperties()` should make a defensive copy to be absolutely correct.
as a reflection, there really is a lot to worry about once classes become
mutable! although I see why it may be justified, this is the reason I
personally strive so hard to build immutable and state-less abstractions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]