umustafi commented on code in PR #3861:
URL: https://github.com/apache/gobblin/pull/3861#discussion_r1456375368


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -615,6 +615,8 @@ public AddSpecResponse onAddSpec(Spec addedSpec) {
       }
       if (PropertiesUtils.getPropAsBoolean(jobConfig, 
ConfigurationKeys.FLOW_RUN_IMMEDIATELY, "false")) {
         _log.info("RunImmediately requested, hence executing FlowSpec: " + 
addedSpec);
+        // Use 0 for trigger event time of a run-immediately flow
+        
jobConfig.setProperty(ConfigurationKeys.ORCHESTRATOR_TRIGGER_EVENT_TIME_MILLIS_KEY,
 "0");

Review Comment:
   Good point, I don't envision a scenario we would rather skip flows rather 
then use the default trigger timestamp of 0 and execute them. Removed this 
check and updated the PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to