arjun4084346 commented on code in PR #3867:
URL: https://github.com/apache/gobblin/pull/3867#discussion_r1465836473


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopyConfiguration.java:
##########
@@ -120,11 +120,8 @@ public CopyConfigurationBuilder(FileSystem targetFs, 
Properties properties) {
           properties.containsKey(DESTINATION_GROUP_KEY) ? 
Optional.of(properties.getProperty(DESTINATION_GROUP_KEY))
               : Optional.<String>absent();
       this.preserve = 
PreserveAttributes.fromMnemonicString(properties.getProperty(PRESERVE_ATTRIBUTES_KEY));
-      Path publishDirTmp = new 
Path(properties.getProperty(ConfigurationKeys.DATA_PUBLISHER_FINAL_DIR));
-      if (!publishDirTmp.isAbsolute()) {
-        publishDirTmp = new Path(targetFs.getWorkingDirectory(), 
publishDirTmp);
-      }
-      this.publishDir = publishDirTmp;
+
+      this.publishDir = calculatePublishDir(targetFs, properties);

Review Comment:
   this is just refactoring to de-duplicate code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to