Will-Lo commented on code in PR #3868:
URL: https://github.com/apache/gobblin/pull/3868#discussion_r1468236220


##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ProcessWorkUnitsJobLauncher.java:
##########
@@ -93,4 +97,11 @@ public void submitJob(List<WorkUnit> workunits) {
       throw new RuntimeException(e);
     }
   }
+
+  private void setupMDCFromJobState(JobState jobState) {
+    // TODO: log4j2 has better syntax around conditional logging such that the 
key does not need to be included in the value

Review Comment:
   Yeah this is a good point, it might make it harder to set up queries on logs 
though if we keep the keys in the values. I'll change the keys to match what 
the API accepts and format the logs appropriately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to