[ 
https://issues.apache.org/jira/browse/GOBBLIN-1993?focusedWorklogId=902379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902379
 ]

ASF GitHub Bot logged work on GOBBLIN-1993:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jan/24 17:23
            Start Date: 29/Jan/24 17:23
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3869:
URL: https://github.com/apache/gobblin/pull/3869#discussion_r1469949314


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -58,9 +58,10 @@
  * for a flow action event. After acquiring the lease, it persists the flow 
action event to the {@link DagActionStore}
  * to be eventually acted upon by the host with the active DagManager. Once it 
has completed this action, it will mark
  * the lease as completed by calling the
- * {@link MysqlMultiActiveLeaseArbiter.recordLeaseSuccess()} method. Hosts 
that do not gain the lease for the event,
- * instead schedule a reminder using the {@link SchedulerService} to check 
back in on the previous lease owner's
- * completion status after the lease should expire to ensure the event is 
handled in failure cases.
+ * {@link 
MysqlMultiActiveLeaseArbiter#recordLeaseSuccess(MultiActiveLeaseArbiter.LeaseObtainedStatus)}
 method. Hosts
+ * that do not gain the lease for the event, instead schedule a reminder using 
the {@link SchedulerService} to check
+ * back in on the previous lease owner's completion status after the lease 
should expire to ensure the event is handled
+ * in failure cases.

Review Comment:
   Same here if this change is intended in this iceberg PR





Issue Time Tracking
-------------------

    Worklog Id:     (was: 902379)
    Time Spent: 0.5h  (was: 20m)

> Add config to exclude copying 'manifest.json' files during iceberg-distcp
> -------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1993
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1993
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-api
>            Reporter: Kip Kohn
>            Assignee: Hung Tran
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> some iceberg replication schemes don't require moving metadata.json files 
> because the dest-side catalog will generate its own, rather than reusing 
> those from source.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to