phet commented on code in PR #3869:
URL: https://github.com/apache/gobblin/pull/3869#discussion_r1469958187


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -58,9 +58,10 @@
  * for a flow action event. After acquiring the lease, it persists the flow 
action event to the {@link DagActionStore}
  * to be eventually acted upon by the host with the active DagManager. Once it 
has completed this action, it will mark
  * the lease as completed by calling the
- * {@link MysqlMultiActiveLeaseArbiter.recordLeaseSuccess()} method. Hosts 
that do not gain the lease for the event,
- * instead schedule a reminder using the {@link SchedulerService} to check 
back in on the previous lease owner's
- * completion status after the lease should expire to ensure the event is 
handled in failure cases.
+ * {@link 
MysqlMultiActiveLeaseArbiter#recordLeaseSuccess(MultiActiveLeaseArbiter.LeaseObtainedStatus)}
 method. Hosts
+ * that do not gain the lease for the event, instead schedule a reminder using 
the {@link SchedulerService} to check
+ * back in on the previous lease owner's completion status after the lease 
should expire to ensure the event is handled
+ * in failure cases.

Review Comment:
   the link to `recordLinkSuccess` was incorrect javadoc syntax so quick fix 
here (I don't otherwise have near-term plans to edit this file)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to