[ 
https://issues.apache.org/jira/browse/GOBBLIN-1989?focusedWorklogId=902440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902440
 ]

ASF GitHub Bot logged work on GOBBLIN-1989:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jan/24 23:59
            Start Date: 29/Jan/24 23:59
    Worklog Time Spent: 10m 
      Work Description: homatthew commented on code in PR #3843:
URL: https://github.com/apache/gobblin/pull/3843#discussion_r1470388235


##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -43,6 +43,13 @@ public interface GobblinTemporalConfigurationKeys {
 
   String GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_PREFIX = 
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "arg.";
 
+  /**
+   * Suffix for metrics emitted by GobblinTemporalJobLauncher for preventing 
collisions with prod jobs
+   * during testing
+   */
+  String GOBBLIN_TEMPORAL_JOB_METRICS_SUFFIX = PREFIX + "job.metrics.suffix";
+  String DEFAULT_GOBBLIN_TEMPORAL_JOB_METRICS_SUFFIX = "";

Review Comment:
   Since we are still in alpha stages, I'd imagine it's okay to have the 
default include a suffix. But obviously we'd need a TODO for reverting that





Issue Time Tracking
-------------------

    Worklog Id:     (was: 902440)
    Time Spent: 1h 20m  (was: 1h 10m)

> TemporaI: Implementation of GTE for GaaS Observability Event in MR 
> deprecation for distcp
> -----------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1989
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1989
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to