[ 
https://issues.apache.org/jira/browse/GOBBLIN-1999?focusedWorklogId=903433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903433
 ]

ASF GitHub Bot logged work on GOBBLIN-1999:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Feb/24 21:10
            Start Date: 02/Feb/24 21:10
    Worklog Time Spent: 10m 
      Work Description: codecov-commenter commented on PR #3874:
URL: https://github.com/apache/gobblin/pull/3874#issuecomment-1924701971

   ## 
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3874?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: `6 lines` in your changes are missing coverage. Please review.
   > Comparison is base 
[(`f6f1bc5`)](https://app.codecov.io/gh/apache/gobblin/commit/f6f1bc51d3fc020add7e7a1ee6760432f197870d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 38.68% compared to head 
[(`6e70292`)](https://app.codecov.io/gh/apache/gobblin/pull/3874?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 46.75%.
   
   | 
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...modules/utils/FlowCompilationValidationHelper.java](https://app.codecov.io/gh/apache/gobblin/pull/3874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy91dGlscy9GbG93Q29tcGlsYXRpb25WYWxpZGF0aW9uSGVscGVyLmphdmE=)
 | 25.00% | [3 Missing and 3 partials :warning: 
](https://app.codecov.io/gh/apache/gobblin/pull/3874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3874      +/-   ##
   ============================================
   + Coverage     38.68%   46.75%   +8.06%     
   - Complexity     1595    11127    +9532     
   ============================================
     Files           388     2210    +1822     
     Lines         15953    87402   +71449     
     Branches       1577     9611    +8034     
   ============================================
   + Hits           6172    40861   +34689     
   - Misses         9289    42857   +33568     
   - Partials        492     3684    +3192     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3874?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 903433)
    Time Spent: 20m  (was: 10m)

> Fix GaaS flowstatus reporting when multiple leaders execute flow
> ----------------------------------------------------------------
>
>                 Key: GOBBLIN-1999
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1999
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In GaaS multileader there is a race condition where one host will 
> compile/kick off a job, and the other hosts have an expected behavior of 
> compiling the job but avoiding submission until the DagManager supports 
> multiple leaders. The other hosts that run slower will try to check if the 
> current job is running, and then mark the flow as failed at the same time 
> when the leader submits the job. This leads to scenarios where successful 
> flows can be marked as failed flows.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to