umustafi commented on code in PR #3858:
URL: https://github.com/apache/gobblin/pull/3858#discussion_r1483622510


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/NewDagManager.java:
##########
@@ -283,9 +283,10 @@ public void handleKillFlowEvent(KillFlowEvent 
killFlowEvent) {
     }
   }
 
-  //@Subscribe todo uncomment it when new dag manager is ready for resume 
functionality
+  @Subscribe
   public void handleResumeFlowEvent(ResumeFlowEvent resumeFlowEvent) {
     if (!this.dagProcessingEngineEnabled) {
+      log.info("Not handling resume flow event yet.");

Review Comment:
   throw unsupported exception here or make this a warn/error level so it 
doesn't escape notice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to