[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=904636&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-904636
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/24 18:39
Start Date: 12/Feb/24 18:39
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3858:
URL: https://github.com/apache/gobblin/pull/3858#discussion_r1486612080
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementStateStore.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.gobblin.runtime.api.DagActionStore;
+import org.apache.gobblin.service.modules.flowgraph.Dag;
+import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+
+
+/**
+ * An interface to provide abstractions for managing {@link Dag} and {@link
org.apache.gobblin.service.modules.flowgraph.Dag.DagNode} states
+ * and allows add/delete and other functions.
+ */
+public interface DagManagementStateStore {
+ Dag<JobExecutionPlan> getDag(String dagId);
+ Dag<JobExecutionPlan> addDag(String dagId, Dag<JobExecutionPlan> dag);
+ boolean containsDag(String dagId);
+ Dag.DagNode<JobExecutionPlan> getDagNode(String dagNodeId);
+ Dag<JobExecutionPlan> getDagForJob(Dag.DagNode<JobExecutionPlan> dagNode);
Review Comment:
Yea, it returns the `Dag` this `DagNode` belongs to. We do not have a
reference of Dag in DagNode. Dag has references for dags. Should I try to add
dag's reference in each of the dag nodes?
Issue Time Tracking
-------------------
Worklog Id: (was: 904636)
Time Spent: 20h 20m (was: 20h 10m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 20h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
