[
https://issues.apache.org/jira/browse/GOBBLIN-2002?focusedWorklogId=905442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-905442
]
ASF GitHub Bot logged work on GOBBLIN-2002:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Feb/24 22:23
Start Date: 16/Feb/24 22:23
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3878:
URL: https://github.com/apache/gobblin/pull/3878#discussion_r1493035326
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MostlyMySqlDagManagementStateStore.java:
##########
@@ -122,33 +125,36 @@ public Set<String> getFailedDagIds() throws IOException {
}
@Override
+ // todo - updating different mapps here and in addDagNodeState can result in
inconsistency between the maps
public synchronized void deleteDagNodeState(DagManager.DagId dagId,
Dag.DagNode<JobExecutionPlan> dagNode) {
- String dagIdStr = dagId.toString();
this.jobToDag.remove(dagNode);
this.dagNodes.remove(dagNode.getValue().getId());
- this.dagToDeadline.remove(dagIdStr);
- this.dagToJobs.get(dagIdStr).remove(dagNode);
- if (this.dagToJobs.get(dagIdStr).isEmpty()) {
- this.dagToJobs.remove(dagIdStr);
+ this.dagToDeadline.remove(dagId);
+ this.dagToJobs.get(dagId).remove(dagNode);
+ if (this.dagToJobs.get(dagId).isEmpty()) {
+ this.dagToJobs.remove(dagId);
}
}
+ // todo - updating different mapps here and in deleteDagNodeState can result
in inconsistency between the maps
Review Comment:
I don't believe there's concern, since both methods are `synchronized`. in
fact, there's not need for CHM, since method-level synchronization
Issue Time Tracking
-------------------
Worklog Id: (was: 905442)
Time Spent: 8h 50m (was: 8h 40m)
> create MostlyInMemoryDagManagementStateStore to merge UserQuotaManager,
> DagStateStore and in-memory dag maps used in DagManager
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2002
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2002
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> this will help in refactoring DagManager
--
This message was sent by Atlassian Jira
(v8.20.10#820010)