[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=906731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906731
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/24 23:46
Start Date: 23/Feb/24 23:46
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3858:
URL: https://github.com/apache/gobblin/pull/3858#discussion_r1501241670
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagement.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration;
+
+import java.io.IOException;
+
+import org.apache.gobblin.runtime.api.FlowSpec;
+import org.apache.gobblin.service.modules.flowgraph.Dag;
+import org.apache.gobblin.service.modules.orchestration.proc.DagProc;
+import org.apache.gobblin.service.modules.orchestration.task.DagTask;
+import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+
+
+/**
+ * An interface to provide abstractions for managing operations on Dag.
+ */
+public interface DagManagement {
+
+ void addDag(FlowSpec flowSpec, Dag<JobExecutionPlan> dag, boolean persist,
boolean setStatus) throws IOException;
+ boolean hasNext();
+
+ DagTask<DagProc> next();
Review Comment:
these two belong in a separate interface, which I suggest naming
`DagTaskStream`. that would `extends Iterator<DagProc>`.
the reason for the separate interface is that I don't envision any client
who should both `addDag` and `next`. AFAICT a client either does ONE OR THE
OTHER, not both.
thereafter create one impl class for both - e.g.
```
DagManagementTaskStreamImpl implements DagManagement, DagTaskStream
```
Issue Time Tracking
-------------------
Worklog Id: (was: 906731)
Time Spent: 24h (was: 23h 50m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 24h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
