umustafi commented on code in PR #3885:
URL: https://github.com/apache/gobblin/pull/3885#discussion_r1513382138
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/GeneralLeaseArbitrationHandler.java:
##########
@@ -0,0 +1,120 @@
+package org.apache.gobblin.service.modules.orchestration;
+
+import java.io.IOException;
+
+import org.quartz.SchedulerException;
+
+import com.google.common.base.Optional;
+import com.typesafe.config.Config;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.apache.gobblin.instrumented.Instrumented;
+import org.apache.gobblin.metrics.ContextAwareCounter;
+import org.apache.gobblin.metrics.ContextAwareMeter;
+import org.apache.gobblin.metrics.MetricContext;
+import org.apache.gobblin.metrics.ServiceMetricNames;
+import org.apache.gobblin.runtime.api.DagActionStore;
+import org.apache.gobblin.runtime.api.MultiActiveLeaseArbiter;
+import org.apache.gobblin.util.ConfigUtils;
+
+
+@Slf4j
+public abstract class GeneralLeaseArbitrationHandler {
+ protected Optional<MultiActiveLeaseArbiter> multiActiveLeaseArbiter;
+ protected Optional<DagActionStore> dagActionStore;
+ protected MetricContext metricContext;
+ private ContextAwareCounter leaseObtainedCount;
+
+ private ContextAwareCounter leasedToAnotherStatusCount;
+
+ private ContextAwareCounter noLongerLeasingStatusCount;
+ private ContextAwareMeter leasesObtainedDueToReminderCount;
+
+ public GeneralLeaseArbitrationHandler(Config config,
Optional<MultiActiveLeaseArbiter> leaseDeterminationStore,
Review Comment:
don't make this optional, remove dagActionStore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
