[
https://issues.apache.org/jira/browse/GOBBLIN-2004?focusedWorklogId=908976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908976
]
ASF GitHub Bot logged work on GOBBLIN-2004:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/24 18:44
Start Date: 08/Mar/24 18:44
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3891:
URL: https://github.com/apache/gobblin/pull/3891#discussion_r1518038369
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/AbstractYarnAppSecurityManager.java:
##########
@@ -17,167 +17,50 @@
package org.apache.gobblin.yarn;
-import java.io.IOException;
+import java.util.Optional;
import java.util.UUID;
-import java.util.concurrent.Executors;
-import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.ScheduledFuture;
-import java.util.concurrent.TimeUnit;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
-import org.apache.hadoop.fs.permission.FsAction;
-import org.apache.hadoop.fs.permission.FsPermission;
-import org.apache.hadoop.security.Credentials;
import org.apache.helix.Criteria;
import org.apache.helix.HelixManager;
import org.apache.helix.InstanceType;
import org.apache.helix.model.Message;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Optional;
import com.google.common.base.Strings;
-import com.google.common.base.Throwables;
-import com.google.common.util.concurrent.AbstractIdleService;
import com.typesafe.config.Config;
import org.apache.gobblin.cluster.GobblinClusterConfigurationKeys;
-import org.apache.gobblin.cluster.GobblinClusterManager;
import org.apache.gobblin.cluster.GobblinHelixMessagingService;
import org.apache.gobblin.util.ConfigUtils;
-import org.apache.gobblin.util.ExecutorsUtils;
-
-import static
org.apache.hadoop.security.UserGroupInformation.HADOOP_TOKEN_FILE_LOCATION;
+import org.apache.gobblin.yarn.helix.HelixMessageSubTypes;
/**
* <p>
- * The super class for key management
- * This class uses a scheduled task to do re-login to re-fetch token on a
- * configurable schedule. It also uses a second scheduled task
- * to renew the delegation token after each login. Both the re-login
interval and the token
- * renewing interval are configurable.
+ * Inherits the {@link AbstractAppSecurityManager} and implements Helix
+ * specific mechanisms for refreshing security credentials.
+ *
+ * NOTE: Although this class contains the term "Yarn", the class does not
specifically
+ * rely on Yarn. It is a generic class that is used by Gobblin Yarn
applications which
+ * are typically managed by Helix
Review Comment:
desc suggests helix to be an integral part, but given you just made it
optional, let's rework javadoc to clarify/reconcile
Issue Time Tracking
-------------------
Worklog Id: (was: 908976)
Time Spent: 40m (was: 0.5h)
> Make a Gobblin yarn app launcher that does not depend on Helix
> --------------------------------------------------------------
>
> Key: GOBBLIN-2004
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2004
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
