phet commented on code in PR #3858: URL: https://github.com/apache/gobblin/pull/3858#discussion_r1518207579
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.orchestration.proc; + +import java.io.IOException; + +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.annotation.Alpha; +import org.apache.gobblin.configuration.State; +import org.apache.gobblin.instrumented.Instrumented; +import org.apache.gobblin.metrics.MetricContext; +import org.apache.gobblin.metrics.event.EventSubmitter; +import org.apache.gobblin.service.modules.orchestration.DagManagementStateStore; +import org.apache.gobblin.service.modules.orchestration.task.DagTask; + + +/** + * Responsible for performing the actual work for a given {@link DagTask} by first initializing its state, performing + * actions based on the type of {@link DagTask} and finally submitting an event to the executor. + */ +@Alpha +@Slf4j +public abstract class DagProc<S, T> { + protected static final MetricContext metricContext = Instrumented.getMetricContext(new State(), DagProc.class); + protected static final EventSubmitter eventSubmitter = new EventSubmitter.Builder( + metricContext, "org.apache.gobblin.service").build(); + + public final void process(DagManagementStateStore dagManagementStateStore) throws IOException { + S state = initialize(dagManagementStateStore); // todo - retry + T result = act(dagManagementStateStore, state); // todo - retry + commit(dagManagementStateStore, result); // todo - retry + } + + protected abstract S initialize(DagManagementStateStore dagManagementStateStore) throws IOException; + + protected abstract T act(DagManagementStateStore dagManagementStateStore, S state) throws IOException; + + protected abstract void sendNotification(T result, EventSubmitter eventSubmitter) throws IOException; + + // todo - commit the modified dags to the persistent store, maybe not required for InMem dagManagementStateStore + protected abstract void commit(DagManagementStateStore dagManagementStateStore, T result); Review Comment: even for the non-in-memory, I believe this can go away, with everything handled completely within `act`. if you want to leave in for now to wait and see, that's ok, but let's make it non-`abstract` and provide an empty impl, so we don't require each derived class to implement a method that may be unnecessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
