phet commented on code in PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#discussion_r1520485487


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaAvroJobStatusMonitor.java:
##########
@@ -154,6 +154,7 @@ public org.apache.gobblin.configuration.State 
parseJobStatus(GobblinTrackingEven
         break;
       case TimingEvent.FlowTimings.FLOW_SUCCEEDED:
       case TimingEvent.LauncherTimings.JOB_SUCCEEDED:
+      case TimingEvent.LauncherTimings.JOB_COMPLETE:

Review Comment:
   is the alt. to adding this in KafkaAvroJSM to instead have 
`ExecuteGobblinWorkflowImpl` emit `JOB_SUCCEEDED`?  if that's what 
gobblin-on-MR emitted, I'd prefer to fix the new producer rather than change 
the long-time consumer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to