arjun4084346 commented on code in PR #3883:
URL: https://github.com/apache/gobblin/pull/3883#discussion_r1520941213


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/NewestKSelectionPolicy.java:
##########
@@ -61,6 +63,12 @@ public class NewestKSelectionPolicy<T extends 
DatasetVersion> implements Version
    */
   public static final String NEWEST_K_VERSIONS_NOTSELECTED_KEY = 
"selection.newestK.versionsNotSelected";
 
+  /**
+   * This denotes to use iterator for fetching all the versions of dataset.
+   * If true, this can't be used along with NewestKSelectionPolicy
+   */
+  public static final String VERSION_FINDER_ITERATOR = 
"version.finder.iterator";

Review Comment:
   lets name it interrogative type , how about SHOULD_ITERATE_VERSIONS ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to