[
https://issues.apache.org/jira/browse/GOBBLIN-2015?focusedWorklogId=909708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909708
]
ASF GitHub Bot logged work on GOBBLIN-2015:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/24 16:51
Start Date: 13/Mar/24 16:51
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3893:
URL: https://github.com/apache/gobblin/pull/3893#discussion_r1523611684
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/MostlyMySqlDagManagementStateStoreTest.java:
##########
@@ -52,14 +52,9 @@ public class MostlyMySqlDagManagementStateStoreTest {
private static final String TEST_PASSWORD = "testPassword";
private static final String TEST_DAG_STATE_STORE = "TestDagStateStore";
private static final String TEST_TABLE = "quotas";
- static ITestMetastoreDatabase testMetastoreDatabase;
-
-
- @BeforeClass
- public void setUp() throws Exception {
- // Setting up mock DB
- testMetastoreDatabase = TestMetastoreDatabaseFactory.get();
+ public static MostlyMySqlDagManagementStateStore
getDummyDMSS(ITestMetastoreDatabase testMetastoreDatabase) throws Exception {
+ MostlyMySqlDagManagementStateStore dagManagementStateStore;
Review Comment:
I mean, it is a static method now, used in other classes also. Kinda makes
sense to declare them ahead. Anyway, moved in the end.
Issue Time Tracking
-------------------
Worklog Id: (was: 909708)
Time Spent: 2.5h (was: 2h 20m)
> implement LaunchDagProc
> -----------------------
>
> Key: GOBBLIN-2015
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2015
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
