arjun4084346 commented on code in PR #3893:
URL: https://github.com/apache/gobblin/pull/3893#discussion_r1523611684
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/MostlyMySqlDagManagementStateStoreTest.java:
##########
@@ -52,14 +52,9 @@ public class MostlyMySqlDagManagementStateStoreTest {
private static final String TEST_PASSWORD = "testPassword";
private static final String TEST_DAG_STATE_STORE = "TestDagStateStore";
private static final String TEST_TABLE = "quotas";
- static ITestMetastoreDatabase testMetastoreDatabase;
-
-
- @BeforeClass
- public void setUp() throws Exception {
- // Setting up mock DB
- testMetastoreDatabase = TestMetastoreDatabaseFactory.get();
+ public static MostlyMySqlDagManagementStateStore
getDummyDMSS(ITestMetastoreDatabase testMetastoreDatabase) throws Exception {
+ MostlyMySqlDagManagementStateStore dagManagementStateStore;
Review Comment:
I mean, it is a static method now, used in other classes also. Kinda makes
sense to declare them ahead. Anyway, moved in the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
