[
https://issues.apache.org/jira/browse/GOBBLIN-2004?focusedWorklogId=910058&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910058
]
ASF GitHub Bot logged work on GOBBLIN-2004:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/24 07:02
Start Date: 15/Mar/24 07:02
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3891:
URL: https://github.com/apache/gobblin/pull/3891#discussion_r1525827544
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/AbstractTokenRefresher.java:
##########
@@ -86,69 +83,60 @@ public AbstractAppSecurityManager(Config config, FileSystem
fs, Path tokenFilePa
GobblinYarnConfigurationKeys.DEFAULT_TOKEN_RENEW_INTERVAL_IN_MINUTES);
this.loginExecutor = Executors.newSingleThreadScheduledExecutor(
- ExecutorsUtils.newThreadFactory(Optional.of(LOGGER),
Optional.of("KeytabReLoginExecutor")));
+ ExecutorsUtils.newThreadFactory(Optional.of(log),
Optional.of("KeytabReLoginExecutor")));
this.tokenRenewExecutor = Executors.newSingleThreadScheduledExecutor(
- ExecutorsUtils.newThreadFactory(Optional.of(LOGGER),
Optional.of("TokenRenewExecutor")));
+ ExecutorsUtils.newThreadFactory(Optional.of(log),
Optional.of("TokenRenewExecutor")));
}
@Override
protected void startUp() throws Exception {
- LOGGER.info("Starting the " + this.getClass().getSimpleName());
-
- LOGGER.info(
- String.format("Scheduling the login task with an interval of %d
minute(s)", this.loginIntervalInMinutes));
+ log.info("Starting the {}", this.getClass().getSimpleName());
+ log.info("Scheduling the login task with an interval of {} minute(s)",
this.loginIntervalInMinutes);
Review Comment:
the reason I like combining consecutive msgs into one is to avoid
interleaving with other unrelated msgs
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/helix/HelixClusterLifecycleManager.java:
##########
@@ -43,6 +43,32 @@
import org.apache.gobblin.util.ConfigUtils;
+/**
+ * The HelixClusterLifecycleManager class is responsible for managing the
lifecycle of a Helix cluster in a Gobblin application.
+ * It provides methods to create and connect to a Helix cluster, send shutdown
requests, and send token file updated messages.
+ *
+ * The class uses the GobblinClusterConfigurationKeys and
GobblinHelixConstants classes for configuration keys and constants.
+ * It also relies on the GobblinClusterManager and
GobblinHelixMessagingService classes for managing the Gobblin cluster and
+ * sending messages to the Helix cluster, respectively.
+ *
+ * To use this class, create an instance with a Config object containing the
necessary configuration properties. The class will
+ * automatically connect to the Helix cluster and create the cluster if
necessary. To close the connection and send a shutdown
+ * request, call the close() method.
+ *
+ * Note: This class requires a ZooKeeper connection string and a Helix cluster
name to be provided in the configuration.
Review Comment:
better would be naming each of those config keys explicitly
Issue Time Tracking
-------------------
Worklog Id: (was: 910058)
Time Spent: 3h 50m (was: 3h 40m)
> Make a Gobblin yarn app launcher that does not depend on Helix
> --------------------------------------------------------------
>
> Key: GOBBLIN-2004
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2004
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)