Will-Lo opened a new pull request, #3900: URL: https://github.com/apache/gobblin/pull/3900
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-2020 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): There are a few bugs in Gobblin-Temporal execution mode: 1. If the publishing step fails, the activity does not report a failure due to missing a step post commit to check the dataset states 2. No GTEs are emitted upon job failure, which makes tracking difficult 3. Some metadata propagation for flow execution ID with workflows is incorrect due to a bug reading worker configs instead of job props 4. The GenerateWus activity does not return the right number of workunits created due to counting top level multiworkunits This PR addresses the above 4 issues and resolves them ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Confirmed that flows can actually fail due to failed commits, number of tasks processed by workunit generation and task processing is matching, concurrent flows will read from job Props and not worker configs which lead to duplicate workflow name conflicts. ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
