phet commented on code in PR #3900:
URL: https://github.com/apache/gobblin/pull/3900#discussion_r1537939847
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/impl/GenerateWorkUnitsImpl.java:
##########
@@ -75,7 +75,7 @@ public int generateWorkUnits(Properties jobProps,
EventSubmitterContext eventSub
JobStateUtils.writeWorkUnits(workUnits, workDirRoot, jobState, fs);
JobStateUtils.writeJobState(jobState, workDirRoot, fs);
- return workUnits.size();
+ return jobState.getTaskCount();
Review Comment:
since I got it wrong the first time, this likely deserves a comment.
also, I may have forgotten to log the count anywhere, yet it could be
meaningful to log both the MWUs and WUs/tasks count. (doing so might even do
double duty-duty in lieu of that comment I just suggested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
