[
https://issues.apache.org/jira/browse/GOBBLIN-2022?focusedWorklogId=911376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911376
]
ASF GitHub Bot logged work on GOBBLIN-2022:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/24 20:34
Start Date: 25/Mar/24 20:34
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1538176933
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -70,16 +53,16 @@ public class LaunchDagProc extends
DagProc<Optional<Dag<JobExecutionPlan>>, Opti
metricContext.newContextAwareGauge(ServiceMetricNames.FLOW_ORCHESTRATION_DELAY,
orchestrationDelayCounter::get));
}
- @Override
- protected DagManager.DagId getDagId() {
- return this.launchDagTask.getDagId();
+ public LaunchDagProc(LaunchDagTask dagTask, FlowCompilationValidationHelper
flowCompilationValidationHelper) {
+ this.dagTask = dagTask;
+ this.flowCompilationValidationHelper = flowCompilationValidationHelper;
}
@Override
protected Optional<Dag<JobExecutionPlan>> initialize(DagManagementStateStore
dagManagementStateStore)
throws IOException {
try {
- DagActionStore.DagAction dagAction = this.launchDagTask.getDagAction();
+ DagActionStore.DagAction dagAction = this.dagTask.getDagAction();
Review Comment:
pulling out the `DagAction` breaks encapsulation and seems best avoided.
could we rework to add a method `DagId::getFlowId` (to `DagId`)?
then, all we need is `DagProc::getDagId`:
```
DagId dagId = this.getDagId();
FlowSpec flowSpec = loadFlowSpec(dmss, dagId);
flowSpec.addProperty(..., dagId.getFlowExecutionId());
```
Issue Time Tracking
-------------------
Worklog Id: (was: 911376)
Time Spent: 0.5h (was: 20m)
> create dag proc for taking actions on job completion
> ----------------------------------------------------
>
> Key: GOBBLIN-2022
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2022
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
