[
https://issues.apache.org/jira/browse/GOBBLIN-2025?focusedWorklogId=911419&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-911419
]
ASF GitHub Bot logged work on GOBBLIN-2025:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/24 22:53
Start Date: 25/Mar/24 22:53
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3903:
URL: https://github.com/apache/gobblin/pull/3903#issuecomment-2019058594
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3903?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `0%` with `2 lines` in your changes are missing
coverage. Please review.
> Project coverage is 47.43%. Comparing base
[(`058d23d`)](https://app.codecov.io/gh/apache/gobblin/commit/058d23de7a3df4caf6750144f418f29366faf56c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`9c14d5a`)](https://app.codecov.io/gh/apache/gobblin/pull/3903?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on master.
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3903?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...n/data/management/copy/predicates/AlwaysFalse.java](https://app.codecov.io/gh/apache/gobblin/pull/3903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHJlZGljYXRlcy9BbHdheXNGYWxzZS5qYXZh)
| 0.00% | [2 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3903 +/- ##
============================================
- Coverage 48.19% 47.43% -0.77%
+ Complexity 9024 8144 -880
============================================
Files 1765 1554 -211
Lines 68165 61613 -6552
Branches 7336 6990 -346
============================================
- Hits 32851 29224 -3627
+ Misses 32485 29681 -2804
+ Partials 2829 2708 -121
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3903?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 911419)
Time Spent: 20m (was: 10m)
> Add Predicate for alwaysFalse to cover cases where predicates are used but
> can be disabled
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2025
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2025
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In Gobblin, since predicates are loaded via Java class loading and have
> minimal configuration options, this is not possible to invoke the Guava
> predicate class of `ObjectPredicate.alwaysFalse()`.
> We want to enable a way for users to have alwaysFalse as a predicate to match
> the alwaysTrue predicate in scenarios where that configuration is needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
