AndyJiang99 commented on code in PR #3902:
URL: https://github.com/apache/gobblin/pull/3902#discussion_r1538388499
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/publisher/GobblinMCEPublisher.java:
##########
@@ -214,6 +214,7 @@ public static Metrics getMetrics(State state, Path path,
Configuration conf, Nam
return OrcMetrics.fromInputFile(HadoopInputFile.fromPath(path,
conf), MetricsConfig.getDefault(), mapping);
} catch (Exception e) {
//This means the table is not compatible with iceberg, so return a
dummy metric
+ //todo: throw exception here? as it's corrupted file
Review Comment:
These two seem to be contradictory it kind of sounds like. If the table is
not compatible with iceberg, then rather than return a dummy metric (which
indicates the table is not compatible but no underlying issues), we should just
throw the exception due to corrupted file right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
